Skip to content

Fix stub function counts of reexports in pyrefly coverage report - #3527

Closed
jorenham wants to merge 1 commit into
pyrefly-org:mainfrom
jorenham:gh-3524
Closed

jorenham wants to merge 1 commit into
pyrefly-org:mainfrom
jorenham:gh-3524

Conversation

@jorenham

Copy link
Copy Markdown
Collaborator

Summary

I confirmed that this fixes the issue in NumPy in all 21 cases, increasing strict coverage from 87.0% -> 94.3%.

Fixes #3524

Test Plan

This includes unit- and integration tests.

@github-actions

Copy link
Copy Markdown

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@meta-codesync

meta-codesync Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D106045081.

@yangdanny97 yangdanny97 self-assigned this May 22, 2026

@stroxler stroxler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync

meta-codesync Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

@yangdanny97 merged this pull request in 26ad772.

@jorenham
jorenham deleted the gh-3524 branch May 22, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyrefly report counts stub functions as untyped if they're re-exported in the .py module

3 participants